Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Nightly wallet adapter #426

Merged
merged 13 commits into from
Jun 27, 2022
Merged

add Nightly wallet adapter #426

merged 13 commits into from
Jun 27, 2022

Conversation

awojciak
Copy link
Contributor

@awojciak awojciak commented May 23, 2022 •
edited
Loading

Adapter for Nightly wallet.

@NorbertBodziony
Copy link

If for review, extension will be needed please ping me. I will provide internal link.

@awojciak
Copy link
Contributor Author

awojciak commented Jun 7, 2022

@jordansexton hi, I see that this PR didn't get any feedback so far, is there anything else needed besides link to extension?

@jordaaash
Copy link
Collaborator

Hey, I want to address the lack of activity on your PR. Thank you for your patience!

Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment)

Let's discuss in that thread to keep it in one place.

jordaaash
jordaaash reviewed Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.

Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.

packages/starter/example/components/ContextProvider.tsx Outdated Show resolved Hide resolved
packages/wallets/nightly/src/types.ts Outdated Show resolved Hide resolved
packages/wallets/nightly/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nightly/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nightly/src/types.ts Outdated Show resolved Hide resolved
packages/wallets/nightly/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nightly/src/adapter.ts Outdated Show resolved Hide resolved
@awojciak awojciak requested a review from jordaaash June 23, 2022 11:01
jordaaash
jordaaash reviewed Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few small notes

packages/wallets/nightly/src/adapter.ts Show resolved Hide resolved
packages/wallets/nightly/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nightly/src/adapter.ts Outdated Show resolved Hide resolved
@awojciak awojciak requested a review from jordaaash June 24, 2022 19:42
@jordaaash jordaaash merged commit 5e8d93c into anza-xyz:master Jun 27, 2022
@jordaaash
Copy link
Collaborator

Thanks! This should be released today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaaash jordaaash Awaiting requested review from jordaaash

Assignees
No one assigned
Labels
new-adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awojciak @NorbertBodziony @jordaaash